Added gRPC command SetSketchDefaults to change sketch attached board/port
#2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The required information are returned from LoadSketch.
cmaglie
added
type: enhancement
cmaglie
requested review from
kittaakos,
alessio-perugini,
umbynos and
MatteoPologruto
cmaglie
force-pushed
the
remove_some_sketch_access
branch
from
ea6768e to
c03ac6a
Compare
This allows to finally remove wrong access to `sketch.Sketch` from `cli` package.
cmaglie
force-pushed
the
remove_some_sketch_access
branch
from
c03ac6a to
54c4d8f
Compare
Co-authored-by: Alessio Perugini <[email protected]>
cmaglie
force-pushed
the
remove_some_sketch_access
branch
from
935c5b9 to
a10a229
Compare
alessio-perugini
approved these changes
Jun 19, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2217 +/- ##
=======================================
Coverage 62.90% 62.91%
=======================================
Files 218 220 +2
Lines 19452 19477 +25
=======================================
+ Hits 12237 12254 +17
- Misses 6134 6139 +5
- Partials 1081 1084 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Added gRPC API to automatically amend the project file
sketch.yamlwhile running theboard attachcommands.This change removes some of the gRPC API bypasses.
What is the current behavior?
What is the new behavior?
No changes
Does this PR introduce a breaking change, and is titled accordingly?
Yes, a small change in golang API.
Other information